Extend show tech to gather sonic core dumps and resource diagnostics#1403
Draft
pau-hedgehog wants to merge 2 commits intomasterfrom
Draft
Extend show tech to gather sonic core dumps and resource diagnostics#1403pau-hedgehog wants to merge 2 commits intomasterfrom
pau-hedgehog wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the show tech functionality to collect additional diagnostic information from switches, including sonic core dumps and critical resource monitoring data.
Changes:
- Added collection of systemd core dumps from switches
- Enhanced diagnostic output with CRM resource monitoring and additional MAC/route statistics
- Modified
collectShowTechfunction signature to accept VM type for conditional processing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/hhfab/vlabhelpers.go | Added vmType parameter to collectShowTech function and implemented conditional core dump collection for switches |
| pkg/hhfab/show-tech/switch.sh | Extended diagnostic script with MAC address counts, route summaries, CRM resources, and systemd core dump extraction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pau-hedgehog
changed the title
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
pau-hedgehog
force-pushed
the
pau/show-tech-core-dump
branch
from
c25555a to
86dc7d6
Compare
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
pau-hedgehog
force-pushed
the
pau/show-tech-core-dump
branch
from
86dc7d6 to
d2621e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.