Conversation
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull request overview
Adds validation to reject gateway peering configurations that attempt to use “stateful” NAT features (masquerade / portForward) on both sides, reflecting a current dataplane limitation (per internal/issues/260).
Changes:
- Add
Peering.Validate()logic to detect and reject “double stateful NAT” configurations. - Update/extend peering NAT validation tests to cover the newly-forbidden combinations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| api/gateway/v1alpha1/peering_types.go | Adds validation tracking “stateful NAT” usage and errors when used on more than one side. |
| api/gateway/v1alpha1/peering_types_test.go | Updates/introduces tests for double-masquerade and portForward+masquerade rejection, plus static+masquerade allowed case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edipascale
force-pushed
the
pr/ema/forbid-double-masquerade-nat
branch
from
2cd4108 to
f77d832
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
pr/ema/forbid-double-masquerade-nat
branch
from
f77d832 to
d74143a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Temp artifacts published: |
dataplane currently does not support stateful (as in masquerade or portForward) on both sides of a gateway peering, so validate it and forbid it. also forbid stateful + stateless on different sides of a peering, due to dataplane not supporting it yet. Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
edipascale
force-pushed
the
pr/ema/forbid-double-masquerade-nat
branch
from
d74143a to
a918cca
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frostman
added
ci:-vlab
|
🚀 Temp artifacts published: |
dataplane currently does not support stateful (as in masquerade or portForward) on both sides of a gateway peering, so validate it and forbid it. also forbid stateful + stateless on different sides of a peering, due to dataplane not supporting it yet.
Part of https://github.com/githedgehog/internal/issues/260