Conversation
Contributor
Author
|
We could enable GitHub Pages in the repo settings |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the diagram generation and viewer system to use SVG format instead of PNG, and adds support for multiple diagram styles (cisco, hedgehog, and default). The changes include generating new diagram formats, creating SVGs with transparent backgrounds, and implementing an HTML viewer for interactive diagram viewing.
Key changes:
- Add support for multiple DrawIO diagram styles (cisco, hedgehog, default)
- Switch from PNG to SVG format generation for all diagram types
- Implement an HTML viewer generation feature using Go
Reviewed Changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| envs/justfile | Updates diagram generation commands to create multiple styles and SVG outputs, adds HTML viewer generation |
| envs/env-ci-1.l/diagrams/spine-leaf/env-ci-1-spine-leaf.mermaid | Reorders connection definitions in the generated Mermaid diagram |
| envs/env-ci-1.l/diagrams/spine-leaf/env-ci-1-spine-leaf.drawio | Updates DrawIO diagram with reordered connection elements and labels |
| envs/env-ci-1.l/diagrams/spine-leaf/env-ci-1-spine-leaf.dot | Reorders connection definitions in the DOT format diagram |
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
pau-hedgehog
force-pushed
the
pau/fix_diagrams
branch
from
f8fabcb to
5faa415
Compare
Frostman
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diagrams are now in svg format
viewer in action can be seen here: https://raw.githack.com/githedgehog/lab-ci/pau/fix_diagrams/envs/diagram-viewer.html