Skip to content

fix: process repositories in batches to prevent partial sync on large orgs #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roryharness wants to merge 2 commits into
base: main-enterprise
Choose a base branch
from
+17 −6
Open

fix: process repositories in batches to prevent partial sync on large orgs #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc820e9
fix: process repositories in batches to prevent partial sync on large…
roryharness Jun 26, 2026
805f61b
fix: include full-sync.js in Docker image
roryharness Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ LABEL version="1.0" \
## to the image to be as small as possible
COPY package*.json /opt/safe-settings/
COPY index.js /opt/safe-settings/
COPY full-sync.js /opt/safe-settings/
COPY lib /opt/safe-settings/lib

## Install the app and dependencies
Expand Down
22 changes: 16 additions & 6 deletions lib/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,13 +538,23 @@ ${this.results.reduce((x, y) => {

async eachRepositoryRepos (github, log) {
log.debug('Fetching repositories')
return github.paginate('GET /installation/repositories').then(repositories => {
return Promise.all(repositories.map(repository => {
const { owner, name } = repository
return this.checkAndProcessRepo(owner.login, name)
})
const repositories = await github.paginate('GET /installation/repositories')
const CONCURRENCY = 10
const results = []
for (let i = 0; i < repositories.length; i += CONCURRENCY) {
const chunk = repositories.slice(i, i + CONCURRENCY)
const chunkResults = await Promise.allSettled(
chunk.map(({ owner, name }) => this.checkAndProcessRepo(owner.login, name))
)
})
for (const result of chunkResults) {
if (result.status === 'fulfilled') {
results.push(result.value)
} else {
log.error(`Error processing repository in batch: ${result.reason}`)
}
}
}
return results
}

async checkAndProcessRepo (owner, name) {
Expand Down