Add the Valve Map Format (VMF)#7985
Conversation
lildude
left a comment
There was a problem hiding this comment.
This PR is incomplete. You have not followed all of the instructions in the CONTRIBUTING.md file.
We also can not accept this grammar either as it doesn't have a licence. We can only accept grammars with one of the licenses linked in the CONTRIBUTING.md file.
|
I have added a license (MIT) to the grammar, but please let me know what I have not followed in the CONTRIBUTING.MD as I am confused on that! |
lildude
left a comment
There was a problem hiding this comment.
I've also just noticed your samples a huge! If they suppressed in the diff, they're too big. Please replace them with smaller, real world samples.
| vendor/grammars/verilog.tmbundle: | ||
| - source.verilog | ||
| vendor/grammars/vmf-grammar: | ||
| - source.keyvalues |
There was a problem hiding this comment.
I see your grammar is very new. You should make this more specific as this is very generic and very likely to conflict with a grammar that really deals with legitimate key/value data which your samples don't seem to do.
You've not generated the language ID as per step 4. You will also need to re-add your grammar to pull in the licence (see the instructions for replacing a grammar and replace your grammar with the same URL). |
Yeah, VMF files are reasonably large. I can make smaller ones, but they won't reflect real maps in real projects. I'm currently fixing the problems with the grammar and will also re-gen the IDs. |
|
I've just noticed we've already got a "Valve Data Format". How does this differ from a syntax perspective? Would this be better suited as adding this extension to the existing language? It's a data format so won't appear in the stats by default and if it's identical syntax, it saves you having to maintain a grammar. |
|
Valve Data Format is used to store game related metadata. Valve Data Format files store information data for resources, installation scripts, configuration scripts, and visualization elements. Valve Map Format files are the actual map source code used by Valve Hammer and VBSP, VVIS, and VRAD to turn the map into a BSP. They have very different grammar, so using the VDF grammar would not be suitable for VMF. |
|
I have updated the IDs for VMF. |
lildude
left a comment
There was a problem hiding this comment.
You've still not replaced the massive samples with smaller files nor re-added your grammar so that the license file can be cached.
|
I have removed the large VMF and kept the small one (this still has the basics of a VMF). I have cached my grammar license as well. |
Description
The Valve Map Format (VMF) is a data language used for Valve Source engine maps created in the Hammer Editor. It stores map geometry, brush data, and entity properties.
Checklist:
#f79a10