Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the markdown-it dependency from version 14.1.0 to 14.1.1 to address a security vulnerability (Dependabot alert #20). The update includes a critical ReDoS (Regular Expression Denial of Service) fix in the linkify rule.
Changes:
- Updated
markdown-itfrom 14.1.0 to 14.1.1, which includes a performance and security fix - Package-lock.json updated with dependency resolution changes (peer flags removed, fsevents added, platform-specific bindings adjusted)
Reviewed changes
Copilot reviewed 1 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated markdown-it version constraint to ^14.1.1 |
| package-lock.json | Updated lock file with new markdown-it version and dependency tree changes |
| node_modules/markdown-it/package.json | Version bumped to 14.1.1 |
| node_modules/markdown-it/lib/rules_inline/linkify.mjs | ReDoS vulnerability fix - replaced regex with manual loop |
| node_modules/markdown-it/dist/markdown-it.js | Compiled distribution with security fix and minor formatting changes |
| node_modules/markdown-it/dist/index.cjs.js | CommonJS build with security fix |
| node_modules/fsevents/* | Added optional macOS file watcher dependency (2.3.3) |
| node_modules/@unrs/resolver-binding-* | Platform-specific binary package adjustments |
| node_modules/.package-lock.json | Internal npm lock file metadata updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/accessibility-alt-text-bot/security/dependabot/20