Skip to content

Conversation

@progval
Copy link

@progval progval commented Jan 16, 2026

Copilot AI review requested due to automatic review settings January 16, 2026 17:11
@github-actions github-actions bot changed the base branch from main to progval/advisory-improvement-6658 January 16, 2026 17:12
@progval progval changed the title Add missing trailing zeros for packages in NPM and and Go Add missing trailing zeros for Go and NPM packages Jan 16, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request standardizes version numbers in security advisory files for Go and NPM packages by ensuring all versions use three-part semantic versioning (X.Y.Z format). The changes address compatibility requirements for Go version parsers that expect three-part version numbers, and align NPM package versions with their actual published versions which use three parts.

Changes:

  • Updated version numbers from two-part to three-part format across multiple GitHub security advisories
  • Corrected version specifications for Go packages (LXD, Grafana, Kubernetes, Vault, wal-g)
  • Corrected version specifications for NPM packages (react-router, @coinbase/wallet-sdk, @saltcorn/cli, directus)
  • Fixed trailing newline in one advisory file

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
GHSA-w2hg-2v4p-vmh6.json Updated LXD (Go) version ranges from two-part to three-part format
GHSA-cpj6-fhp6-mr6j.json Updated react-router (npm) introduced version to three-part format
GHSA-8rgj-285w-qcq4.json Updated @coinbase/wallet-sdk (npm) introduced version to three-part format
GHSA-mx47-6497-3fv2.json Updated Grafana (Go) introduced version to three-part format
GHSA-wxf3-4fvj-vqqx.json Updated @saltcorn/cli (npm) fixed version to three-part format
GHSA-gggm-66rh-pp98.json Updated directus (npm) introduced version to three-part format
GHSA-wq4c-wm6x-jw44.json Added missing trailing newline to file
GHSA-m25m-5778-fm22.json Updated Grafana (Go) introduced version to three-part format
GHSA-57gg-cj55-q5g2.json Updated Vault (Go) introduced version to three-part format
GHSA-2jq6-ffph-p4h8.json Updated Kubernetes (Go) introduced version to three-part format
GHSA-vrmr-f2qh-3hhf.json Updated wal-g (Go) fixed version to three-part format
Comments suppressed due to low confidence (3)

advisories/github-reviewed/2025/10/GHSA-w2hg-2v4p-vmh6/GHSA-w2hg-2v4p-vmh6.json:5

  • The modified and published dates are set to November 2025 and October 2025 respectively, which were future dates relative to the current date of January 16, 2026. While these are now in the past, the modified date of November 5, 2025 should likely be updated to reflect the actual date of this modification.
  "modified": "2025-11-05T22:08:31Z",
  "published": "2025-10-02T21:21:33Z",

advisories/github-reviewed/2025/04/GHSA-cpj6-fhp6-mr6j/GHSA-cpj6-fhp6-mr6j.json:5

  • The modified and published dates are set to April 2025, which were future dates at some point. While these are now in the past relative to January 16, 2026, the modified date should be updated to reflect the actual date of this modification.
  "modified": "2025-04-25T14:34:15Z",
  "published": "2025-04-24T16:31:32Z",

advisories/github-reviewed/2025/02/GHSA-8rgj-285w-qcq4/GHSA-8rgj-285w-qcq4.json:5

  • The modified and published dates are set to February 2025, which were future dates at some point. While these are now in the past relative to January 16, 2026, the modified date should be updated to reflect the actual date of this modification.
  "modified": "2025-02-10T17:59:09Z",
  "published": "2025-02-10T17:59:09Z",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

progval and others added 2 commits January 16, 2026 18:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

advisories/github-reviewed/2025/10/GHSA-w2hg-2v4p-vmh6/GHSA-w2hg-2v4p-vmh6.json:5

  • The 'modified' date (2025-11-05) and 'published' date (2025-10-02) are in the future. The current date is January 16, 2026, making these dates approximately 2-4 months in the past from now, but they appear to be in year 2025 which suggests they may need to be corrected to 2024 if they were meant to reference past events, or verified if they are intentionally set for future publication.
  "modified": "2025-11-05T22:08:31Z",
  "published": "2025-10-02T21:21:33Z",

advisories/github-reviewed/2025/04/GHSA-cpj6-fhp6-mr6j/GHSA-cpj6-fhp6-mr6j.json:5

  • The 'modified' date (2025-04-25) and 'published' date (2025-04-24) are in the future. The current date is January 16, 2026, making these dates approximately 9 months in the past from now, but they appear to be in year 2025. These dates should be verified to ensure they accurately reflect when the advisory was published and last modified.
  "modified": "2025-04-25T14:34:15Z",
  "published": "2025-04-24T16:31:32Z",

advisories/github-reviewed/2025/02/GHSA-8rgj-285w-qcq4/GHSA-8rgj-285w-qcq4.json:5

  • The 'modified' and 'published' dates (2025-02-10) are in the future. The current date is January 16, 2026, making this date approximately 11 months in the past from now, but it appears to be in year 2025. This date should be verified to ensure it accurately reflects when the advisory was published.
  "modified": "2025-02-10T17:59:09Z",
  "published": "2025-02-10T17:59:09Z",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shelbyc
Copy link
Contributor

shelbyc commented Jan 16, 2026

Hi @progval, due to the way the community contributions system works, a PR can only be accepted if it changes one advisory at a time. I can make the changes you're suggesting, but the changes wouldn't merge the PR and you wouldn't get credit. You have two options:

  1. If you're not worried about receiving credit and just want the advisories to have their VVRs changed, I can make the changes manually and close the PR when that process is finished.
  2. If you want credit on the advisories, you can resubmit each advisory as its own PR.

Let me know which option you would prefer.

@progval
Copy link
Author

progval commented Jan 16, 2026

I'm not worried about credit. Thanks!

@shelbyc
Copy link
Contributor

shelbyc commented Jan 16, 2026

Cool, I'll break down how I handled the following advisories here:

@shelbyc
Copy link
Contributor

shelbyc commented Jan 16, 2026

Closing this PR because I can't merge it, but the conversation can continue as needed.

@shelbyc shelbyc closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants