Skip to content

[GHSA-m34p-749j-x6m6] js-toml has silent type confusion via falsy-primitive duplicate-key bypass#8182

Open
krotname wants to merge 1 commit into
krotname/advisory-improvement-8182from
krotname-GHSA-m34p-749j-x6m6
Open

[GHSA-m34p-749j-x6m6] js-toml has silent type confusion via falsy-primitive duplicate-key bypass#8182
krotname wants to merge 1 commit into
krotname/advisory-improvement-8182from
krotname-GHSA-m34p-749j-x6m6

Conversation

@krotname

Copy link
Copy Markdown

Updates

  • References

Comments
Add upstream release and fix commit references for the existing patched version 1.1.2.

The v1.1.2 release notes explicitly state that the release fixes GHSA-m34p-749j-x6m6. The referenced commit switches the duplicate-key existence checks from truthy tests to the in operator, causing falsy-primitive duplicate keys to raise parse errors as required.

No advisory metadata, affected range, patched version, severity, or description changes are proposed.

@github

github commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Hi there @sunnyadn! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Copilot stopped work on behalf of krotname due to an error June 28, 2026 22:01
@github-actions github-actions Bot changed the base branch from main to krotname/advisory-improvement-8182 June 28, 2026 22:02
@sunnyadn

Copy link
Copy Markdown

Confirmed — these references are accurate. Both the fix commit (e0504fa, "treat falsy-primitive duplicate keys as parse errors") and the v1.1.2 release tag correctly point to the patch for GHSA-m34p-749j-x6m6. Thanks @krotname for the improvement; this LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants