fix(python): clean up setuptools usage and drop redundant/unnecessary lock files#449
Open
brettcannon wants to merge 3 commits intogithub:mainfrom
Open
fix(python): clean up setuptools usage and drop redundant/unnecessary lock files#449brettcannon wants to merge 3 commits intogithub:mainfrom
brettcannon wants to merge 3 commits intogithub:mainfrom
Conversation
Use of `setup.py` is redundant. This leads to more accurate metadata: ```diff 17c17 < Requires-Python: >=3.8 --- > Requires-Python: >=3.9 29d28 < Dynamic: requires-python ```
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to modernize the Python SDK's build configuration by removing redundant files and consolidating setup configuration into pyproject.toml. The changes improve metadata accuracy (e.g., correctly specifying Python >=3.9 instead of >=3.8) and attempt to simplify the package structure.
Changes:
- Removes
setup.pyin favor ofpyproject.tomldeclarative configuration - Removes
test-requirements.txt(dependencies now managed via[project.optional-dependencies]) - Removes
uv.lockand adds it to.gitignore - Simplifies setuptools package configuration in
pyproject.toml
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/setup.py | Removed - redundant with pyproject.toml declarative configuration |
| python/test-requirements.txt | Removed - test dependencies now in pyproject.toml dev extras |
| python/uv.lock | Removed - all 579 lines of lock file deleted |
| python/pyproject.toml | Simplified setuptools configuration from packages.find to explicit packages list |
| python/.gitignore | Added uv.lock to ignore list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leads to more accurate metadata that is declared in a single location:
This should close #397 as redundant, but #168 is still pertinent.