Haxe logo#4826
Conversation
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
|
what i do wrong? |
jmeridth
left a comment
There was a problem hiding this comment.
This looks good. Confirmed the logo matches what is at https://github.com/HaxeFoundation
|
Looks like you have some linting to possibly fix. I'll look at this in a minute. |
|
The test failure is because the filename needs to be |
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
quakec added Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
kenyonj
left a comment
There was a problem hiding this comment.
Looks like there are a couple of extra files in this PR that don't match the required formats. Can this be cleaned up?
piratabrasileiro1
left a comment
There was a problem hiding this comment.
thanks for the help
yes, they are simple mistake |
this still needs to be done |
|
I'll fix this with a fresh PR that preserves your attribution @piratabrasileiro1 , thank you! |
|
Thanks, this is a strange error |
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
HAXE logo image
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.