Skip to content

Haxe logo#4826

Closed
piratabrasileiro1 wants to merge 14 commits into
github:mainfrom
piratabrasileiro1:main
Closed

Haxe logo#4826
piratabrasileiro1 wants to merge 14 commits into
github:mainfrom
piratabrasileiro1:main

Conversation

@piratabrasileiro1

@piratabrasileiro1 piratabrasileiro1 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

HAXE logo image

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
@piratabrasileiro1 piratabrasileiro1 requested a review from a team as a code owner July 16, 2025 01:23
@piratabrasileiro1 piratabrasileiro1 changed the title Add files via upload Haxe logo Jul 16, 2025
@piratabrasileiro1

Copy link
Copy Markdown
Contributor Author

what i do wrong?

@jmeridth jmeridth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Confirmed the logo matches what is at https://github.com/HaxeFoundation

@jmeridth

Copy link
Copy Markdown
Contributor

Looks like you have some linting to possibly fix. I'll look at this in a minute.

@jmeridth

Copy link
Copy Markdown
Contributor

The test failure is because the filename needs to be haxe.png and not haxelogo.png

piratabrasileiro1 and others added 10 commits July 24, 2025 20:33
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
quakec added

Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>
Signed-off-by: Gabriel Lima Lopes <135924740+piratabrasileiro1@users.noreply.github.com>

@kenyonj kenyonj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are a couple of extra files in this PR that don't match the required formats. Can this be cleaned up?

@piratabrasileiro1 piratabrasileiro1 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the help

@piratabrasileiro1

Copy link
Copy Markdown
Contributor Author

Looks like there are a couple of extra files in this PR that don't match the required formats. Can this be cleaned up?

yes, they are simple mistake

@kenyonj

kenyonj commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Looks like there are a couple of extra files in this PR that don't match the required formats. Can this be cleaned up?

this still needs to be done

@kenyonj kenyonj removed request for jmeridth and kenyonj August 18, 2025 15:34

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahpook ahpook mentioned this pull request Sep 7, 2025
13 tasks
@ahpook

ahpook commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

I'll fix this with a fresh PR that preserves your attribution @piratabrasileiro1 , thank you!

@ahpook ahpook closed this Sep 7, 2025
@piratabrasileiro1

Copy link
Copy Markdown
Contributor Author

Thanks, this is a strange error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants