Revert core shim for Node.js execution in MCP servers#16151
Closed
Revert core shim for Node.js execution in MCP servers#16151
Conversation
- Create core_shim.cjs with minimal core object implementation - Load shim in safe-inputs and safe-outputs MCP servers - Add core_shim.cjs to setup.sh file lists for both servers - Add comprehensive tests for core shim Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a shim for GitHub script core object in Node.js
Add core shim for Node.js execution in MCP servers
Feb 16, 2026
pelikhan
reviewed
Feb 16, 2026
actions/setup/js/core_shim.cjs
Outdated
| * Mark the action as failed with an error message | ||
| * @param {string} message - The failure message | ||
| */ | ||
| setFailed(message) { |
Contributor
|
@copilot keep working |
Contributor
Author
Removed the core shim implementation in 2d750cc. The MCP servers and setup.sh have been reverted to their original state. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add core shim for Node.js execution in MCP servers
Revert core shim for Node.js execution in MCP servers
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the core shim implementation that was initially added to handle
@actions/coreunavailability in Node.js environments.Changes
core_shim.cjs- Deleted the minimal@actions/coreshim implementationcore_shim.test.cjs- Deleted associated testssafe_inputs_mcp_server.cjsandsafe_outputs_mcp_server.cjsto original statecore_shim.cjsfromSAFE_INPUTS_FILESandSAFE_OUTPUTS_FILESinsetup.shRationale
The core shim approach is not needed. Code that may run outside GitHub Actions context should use
typeof core !== "undefined"checks instead of relying on a global shim. This pattern is already established in existing utility modules likepath_helpers.cjs.Example of Correct Pattern
This approach is more flexible and doesn't create coupling to a specific shim implementation.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
✨ PR Review Safe Output Test - Run 22074209714