Skip to content

Move-tables: Lag measurement mods#1721

Merged
zacharysierakowski merged 2 commits into
feature-move-tablesfrom
lag-measurement-mods
Jun 23, 2026
Merged

Move-tables: Lag measurement mods#1721
zacharysierakowski merged 2 commits into
feature-move-tablesfrom
lag-measurement-mods

Conversation

@zacharysierakowski

Copy link
Copy Markdown

Closes https://github.com/github/database-infrastructure/issues/8208

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: https://github.com/github/database-infrastructure/issues/8208
Related issue (public): #1681

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR fixes up the status message. Specifically, it addresses the "lag" measurement emitted in move-tables mode - where there is no heartbeat logic running.

  • An applier-side "last applied event timestamp" updated after each successful DML batch.
  • A derived "writer lag" metric exposed in: the periodic status line in move table mode (replacing the heartbeat-lag field), the hooks environment as GH_OST_BINLOG_WRITER_LAG_SECONDS (§1.7).
  • An idle rule on the streamer: if no events have arrived for the configured heartbeat interval, bump the timestamp to now so silence is not interpreted as falling behind.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@zacharysierakowski zacharysierakowski self-assigned this Jun 22, 2026
@zacharysierakowski zacharysierakowski added the feature-move-tables PRs that are associated with the new move-tables feature label Jun 22, 2026
@zacharysierakowski zacharysierakowski changed the base branch from master to feature-move-tables June 22, 2026 17:12
@zacharysierakowski zacharysierakowski changed the title Lag measurement mods Move-tables: Lag measurement mods Jun 22, 2026
@zacharysierakowski zacharysierakowski marked this pull request as ready for review June 22, 2026 17:23
Copilot AI review requested due to automatic review settings June 22, 2026 17:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@zacharysierakowski zacharysierakowski merged commit a3a29ce into feature-move-tables Jun 23, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-move-tables PRs that are associated with the new move-tables feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants