Skip to content

Conversation

@gfarb
Copy link
Contributor

@gfarb gfarb commented Dec 19, 2022

  • Upgrade to Node LTS (and use .nvmrc)
  • Remove redundant Node module installations
  • Clean up Compile Release Notes & Delete Artifacts steps in .github/workflows/release-branch-merge-handler.yml
  • Fix bugs in Codespaces setup script i,e bug preventing installation of plugins & removal of node_modules to prevent error on rebuild
  • Update several dependencies
  • Switch to @salesforce/cli module and convert all commands to use sf

Copy link
Collaborator

@rdietrick rdietrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @gfarb .

Have we tested all of these changes? We should think about ways to automatically test all of the workflows as a PR validating check. We'd probably need to do it in a fork, so that we could create our own environments in which to test everything.

@gfarb
Copy link
Contributor Author

gfarb commented Nov 30, 2023

Looks good to me, @gfarb .

Have we tested all of these changes? We should think about ways to automatically test all of the workflows as a PR validating check. We'd probably need to do it in a fork, so that we could create our own environments in which to test everything.

@rdietrick yeah tested all of them in my fork, albeit that was a while ago it may be a good idea to run through another round of testing. I think I also need to look at dependencies and make sure they are all updated to avoid security "issues".

I think that would be awesome if we could somehow create a validating check, will start to think about how we can accomplish this.


Update:

Before merging in this change in, I actually want to move forward with this PR #58 because this was tested a lot more extensively and is a bit more important

@rdietrick rdietrick merged commit dd9c34d into main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants