Conversation
Update action.ts
Update action.ts
| uses: ./ | ||
| id: ossar | ||
|
|
||
| # Upload results to the Security tab |
There was a problem hiding this comment.
Not sure if we want to upload results from .NET analyzers run to security tab or not, as the analyzers are not restricted to just security analyzers. Will have to talk with @mikadumont to decide
There was a problem hiding this comment.
GitHub would prefer if only security results were in the tab, as noise will make people not pay attention to critical issues. Should likely remove this for now. There may be a way to selectively export security-only rules with Guardian and a policy, although I am unfamiliar if we have that capability now.
| sarif_file: ${{ steps.ossar.outputs.sarifFile }} | ||
| # Run .NET Analyzers | ||
| - name: Run .NET Analyzers | ||
| uses: github/dotnet-analyzers-action@v1 |
There was a problem hiding this comment.
This will likely be the new repo URL, but have to confirm with @mikadumont
There was a problem hiding this comment.
Shouldnt it be called code-analysis?
There was a problem hiding this comment.
Yep, I will fix it up in the cloned repo.
3 participants
This will eventually be cloned into a separate repo. Creating this draft PR for ease of testing + review.