Skip to content

replace hashbrown with std::hashmap#118

Merged
aneubeck merged 3 commits into
mainfrom
aneubeck/hashbrown
Jun 3, 2026
Merged

replace hashbrown with std::hashmap#118
aneubeck merged 3 commits into
mainfrom
aneubeck/hashbrown

Conversation

@aneubeck

@aneubeck aneubeck commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 3, 2026 11:07
@aneubeck aneubeck requested a review from a team as a code owner June 3, 2026 11:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the hash-sorted-map crate’s benchmark harness and accompanying documentation to compare against std::collections::HashMap (with explicit hashers) rather than benchmarking hashbrown directly, and removes the direct hashbrown dependency from the benchmark crate.

Changes:

  • Switch Criterion benchmarks from hashbrown::HashMap/ahash::AHashMap to std::collections::HashMap configured with specific BuildHasher implementations.
  • Update README/optimization writeups to report results and comparisons using the new std::collections::HashMap baselines.
  • Remove hashbrown from crates/hash-sorted-map/benchmarks dependencies.
Show a summary per file
File Description
crates/hash-sorted-map/README.md Updates benchmark comparison labels and adds an explanatory note about std::collections::HashMap/hashbrown.
crates/hash-sorted-map/OPTIMIZATIONS.md Updates benchmark tables/baselines and clarifies relationship to std::collections::HashMap.
crates/hash-sorted-map/benchmarks/performance.rs Replaces benchmarked map implementations with std::collections::HashMap variants using explicit hashers.
crates/hash-sorted-map/benchmarks/Cargo.toml Drops the hashbrown dependency from the benchmark crate.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

Comment thread crates/hash-sorted-map/README.md Outdated
Comment thread crates/hash-sorted-map/OPTIMIZATIONS.md Outdated
aneubeck and others added 2 commits June 3, 2026 13:26
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@aneubeck aneubeck merged commit 0f9c9c8 into main Jun 3, 2026
7 checks passed
@aneubeck aneubeck deleted the aneubeck/hashbrown branch June 3, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants