replace hashbrown with std::hashmap#118
Merged
Merged
Conversation
gorzell
approved these changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the hash-sorted-map crate’s benchmark harness and accompanying documentation to compare against std::collections::HashMap (with explicit hashers) rather than benchmarking hashbrown directly, and removes the direct hashbrown dependency from the benchmark crate.
Changes:
- Switch Criterion benchmarks from
hashbrown::HashMap/ahash::AHashMaptostd::collections::HashMapconfigured with specificBuildHasherimplementations. - Update README/optimization writeups to report results and comparisons using the new
std::collections::HashMapbaselines. - Remove
hashbrownfromcrates/hash-sorted-map/benchmarksdependencies.
Show a summary per file
| File | Description |
|---|---|
| crates/hash-sorted-map/README.md | Updates benchmark comparison labels and adds an explanatory note about std::collections::HashMap/hashbrown. |
| crates/hash-sorted-map/OPTIMIZATIONS.md | Updates benchmark tables/baselines and clarifies relationship to std::collections::HashMap. |
| crates/hash-sorted-map/benchmarks/performance.rs | Replaces benchmarked map implementations with std::collections::HashMap variants using explicit hashers. |
| crates/hash-sorted-map/benchmarks/Cargo.toml | Drops the hashbrown dependency from the benchmark crate. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.