feat(integrations): add omp support#3107
Open
omar2535 wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new built-in integration for the Oh My Pi (omp) coding agent, so Spec Kit can scaffold the standard slash-command templates into .omp/commands/ and manage agent context via AGENTS.md.
Changes:
- Introduces
OmpIntegration(Markdown-based) with CLI dispatch args that support JSON mode via--mode json. - Registers the new integration and adds a dedicated integration test.
- Updates integration catalog and user docs to list
ompand its generated directories.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/omp/__init__.py |
Adds the new OmpIntegration definition and custom build_exec_args behavior. |
src/specify_cli/integrations/__init__.py |
Registers OmpIntegration in the built-in integration registry. |
tests/integrations/test_integration_omp.py |
Adds coverage for omp integration wiring and its JSON-mode exec args. |
integrations/catalog.json |
Adds the omp entry to the built-in integration catalog. |
README.md |
Updates the documented tool-check list to include Oh My Pi. |
docs/upgrade.md |
Documents .omp/commands/ as a generated command location and troubleshooting check. |
docs/reference/integrations.md |
Adds omp to the supported integrations reference table. |
docs/installation.md |
Lists Oh My Pi as a supported agent and adds an --integration omp init example. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 8/8 changed files
- Comments generated: 1
mnriem
requested changes
Jun 23, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
mnriem
requested changes
Jun 23, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve conflict by pulling in upstream/main
mnriem
requested changes
Jun 23, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
Collaborator
|
Please resolve test & lint errors |
…r in issue templates Inherit MarkdownIntegration.build_exec_args so omp picks up shared CLI contract changes (requires_cli gating, extra-args ordering, --model handling) automatically; only specialize the --mode json flag. Also add Oh My Pi / omp to the issue-template agent lists so test_issue_template_agent_lists_match_runtime_integrations passes.
OMP's CLI parser treats `-p`/`--print` as a boolean (one-shot mode) and consumes the prompt as a positional message; the previous inherited `-p <prompt>` shape worked by accident only because `-p` ignores its next token. Build the argv explicitly with flags first and the prompt as a trailing positional, matching upstream args.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Oh My Pi support.
This adds the
ompintegration, scaffolding Spec Kit slash commands into.omp/commands/and usingAGENTS.mdfor agent context.Testing
.venv/bin/specify --helpuv sync --extra test && uv pip install -e . && .venv/bin/python -m pytest tests/integrations/test_integration_omp.py tests/integrations/test_registry.py tests/integrations/test_integration_catalog.py tests/test_agent_config_consistency.py -qspecify init <tmp>/omp-test --integration omp --script sh --ignore-agent-tools.omp/commands/speckit.constitution.mdAGENTS.md.specify/integrations/omp.manifest.jsonAI Disclosure
Code was generated with GPT and Sonnet, then manually reviewed and verified locally by me.