fix(codecs): improve robustness of AVCC/HVCC parsing and remove ful logic#55
fix(codecs): improve robustness of AVCC/HVCC parsing and remove ful logic#55
Conversation
Summary of ChangesHello @gkozlenko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and reliability of AAC, H.264, and H.265 codec parsing. By transitioning to a stateless parsing approach and introducing rigorous input validation, the changes prevent common errors arising from malformed or incomplete configuration data. This ensures that the codec parsing logic is more resilient to unexpected inputs and maintains a consistent internal state, ultimately leading to more stable media processing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the robustness and design of the H.264 and H.265 codec parsers. By removing class-level state, the parse methods are now idempotent and easier to reason about. The introduction of strict bounds checking, version validation, and atomic updates to the parsed units prevents various errors with malformed data and makes the implementation much more resilient. The accompanying unit tests are thorough and cover the new edge cases well. I have one minor suggestion regarding a comment.
gkozlenko
force-pushed
the
codecs-strict-validation
branch
from
6bcbee3 to
16305c9
Compare
…ful logic Refactored H.264 and H.265 codec parsing to be more robust and stateless. Changes: - Removed class-level state `this._pos` and the `_readNalUnit` method; `parse()` is now idempotent and uses local variables. - Implemented strict bounds checks to prevent `RangeError` on malformed or incomplete configuration buffers. - Added validation for configuration version (must be 1). - Enforced NAL unit length size to be 4 bytes, throwing specific errors for unsupported sizes to ensure compatibility. - Ensure `this._units` is only updated after a fully successful parse to prevent inconsistent states. - Added unit tests covering edge cases: null input, short buffers, invalid versions, and unsupported NAL sizes.
Test Coverage Summary Statistics
|
1 participant
Refactored H.264 and H.265 codec parsing to be more robust and stateless.
Changes:
this._posand the_readNalUnitmethod;parse()is now idempotent and uses local variables.RangeErroron malformed or incomplete configuration buffers.this._unitsis only updated after a fully successful parse to prevent inconsistent states.