Skip to content

Resolved TODO items#34

Open
lazza-79 wants to merge 3 commits intov2from
v2-todo-fixes
Open

Resolved TODO items#34
lazza-79 wants to merge 3 commits intov2from
v2-todo-fixes

Conversation

@lazza-79
Copy link
Copy Markdown
Member

@lazza-79 lazza-79 commented May 1, 2026

I have been through the TODO items left from the springboot 4 work.

This should resolve all of these issues and a few extras

Copy link
Copy Markdown
Member

@nvasta nvasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work but as expected there are still a number of things to be clarified.

Have a look at the inline comments.

Response.Status responseStatus;
CapabilityResponseObject capabilityResponseObject = new CapabilityResponseObject();

// Create the Public Key response
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not consistent in all three versions of the library. It is a tedious piece of work, but unfortunately it should be done :(.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This interface doesn't exist in the springboot package. As I said, maybe we need to the remove the PostPublicKey and keep the upload? Anyway, I think one of them would do.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need public key operations in the client?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need public key operations in the client?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need public key operations in the client?

Comment thread .gitignore Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants