Require both CFLAGS and LDFLAGS to be empty in order to skip.#6
Open
basking2 wants to merge 1 commit intoglejeune:masterfrom
Open
Require both CFLAGS and LDFLAGS to be empty in order to skip.#6basking2 wants to merge 1 commit intoglejeune:masterfrom
basking2 wants to merge 1 commit intoglejeune:masterfrom
Conversation
|
Confirm, experienced same problem, this will fix the issue. Also it'll be good to raise "lua not found" message if no lua found in section "["lua", "lua5.1", "lua5.2"].any?"; like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Fedora 20 I observed that installing ruby-lua-0.4.0 succeeded, but the compiled
lua.sodid not know to dynamically load the lua library. It was missing the-lluaflag.examining
extconf.rbshowed the when falling back to usingpkg-configa result is skipped if bothcfandldfare empty. In Fedora 20CFLAGSis empty, and that is not an error, whileLDFLAGShas the missing libraries.I thought the easiest change would be to make the
orandandas you can see in the diff. Ifpkg-confighas nothing to add to the compilation, try again. If it adds anything, assume it is correct and complete.