Conversation
Owner
Author
|
Should refactor this and add common class for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14
PersonandTVSeason_buildmethods are different, they callidsfirst before_ids, so therefore we need setter forids. Unfortunately, that data is not even tested, so this did not come out in any way.Typically it's like this:
python-pytrakt/trakt/movies.py
Lines 125 to 131 in b5dfbeb
but
PersonandTVSeasonhave:python-pytrakt/trakt/people.py
Lines 64 to 70 in b5dfbeb
python-pytrakt/trakt/people.py
Lines 64 to 70 in b5dfbeb