Fix: Do not set deleted items to UserList._items in UserList.remove_items()

[glensc]

Seems like a bug. Does not make sense to set _items to the value of deleted items.

Git blame points to 51b1b7b commit:

51b1b7b0 (moogar0880      2015-02-14 22:05:10 -0500 178)         self._items = items
51b1b7b0 (moogar0880      2015-02-14 22:05:10 -0500 205)         self._items = items

Seems to me the code is copy-paste from def add_items(self, *items)

[simonc56]

Also in def add_items(self, *items) it doesn't make sense to set _items to the value of added items. What about items already in list ?

[glensc]

And get_items appends to the list, if called multiple times with different list value the result would be pointless, i.e it's collection of random things, not a definition of a UserList.

I think get_items was not intended to be used outside the class and it should just return the data rather updating self._items.
the self._items update could be moved to _get.

and addition to that add_items should merge the _items, and remove_items should remove items from _items.

the _items is used for the iter outside the class.