Fix: use builtin dataclasses.fields instead of __annotations__#96
Fix: use builtin dataclasses.fields instead of __annotations__#96purarue wants to merge 1 commit intoglensc:mainfrom
Conversation
in python3.14, computing the __annotations__ is done lazily which leads to an error. see https://docs.python.org/3/whatsnew/3.14.html#implications-for-readers-of-annotations
WalkthroughThe change refactors Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Heres the output in a debugger in python3.13, to show they're the same order: This fixes #95 |
in python3.14, computing the
__annotations__is done lazily whichleads to an error. see
https://docs.python.org/3/whatsnew/3.14.html#implications-for-readers-of-annotations