Open
Conversation
Replace googleapiclient with dataproc python package globocom#15
regismachado
suggested changes
Oct 22, 2020
Contributor
regismachado
left a comment
regismachado
left a comment
There was a problem hiding this comment.
Hello @tacoelho
Please review your code, because it´s added some issues and isn´t make proper use of the dataproc api.
Ware expecting for a complete substituion of googleapi discovery client for the google dataproc api.
| self.__region = region | ||
| self.__logger = logging.getLogger(name=self.__class__.__name__) | ||
| self.__logger = logging.getLogger(cluster_name=self.__class__.__name__) | ||
| self.__client = discovery.build('dataproc', 'v1', http=http) |
Contributor
There was a problem hiding this comment.
Hi, please verify your changes.
You removed discovery import but keep using it in this line.
| import os | ||
| import re | ||
| from googleapiclient import discovery | ||
| from google.cloud import dataproc |
Contributor
There was a problem hiding this comment.
Imported dataproc but it´s not being used
Author
|
Hey, @regismachado I'll check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace googleapiclient with dataproc python package #15
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Minor change to dataproc.py
Fixes # (issue)
#15
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: