Conversation
A detailed description of the usage.
Fix typos
Fix typos
Fix typos
cbkerr
requested review from
kidrahahjo and
syjlee
and removed request for
a team
for more information, see https://pre-commit.ci
b-butler
requested changes
Nov 22, 2022
Member
b-butler
left a comment
b-butler
left a comment
There was a problem hiding this comment.
- workflow.py and label.py seem unnecessary, especially when functions are refactored, move to project.py.
I did not have an opportunity to view the VAE code any any depth currently, but I will when these changes are addressed.
Comment on lines
+266
to
+272
| plt.figure(figsize=(12, 10)) | ||
| plt.scatter(z1_arr, z2_arr, c=colormap(c_arr), s=5) | ||
| plt.colorbar(sm, ticks=np.linspace(0, 10, 10, endpoint=False), label="Ground truth") | ||
| plt.xlabel(r"$z_1$", fontsize=25) | ||
| plt.ylabel(r"$z_2$", fontsize=25) | ||
| plt.title(title_name, fontsize=35) | ||
| plt.savefig(job.fn("latent.jpg")) |
Member
There was a problem hiding this comment.
Use object oriented interface.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
b-butler
approved these changes
Oct 12, 2023
b-butler
requested review from
tommy-waltmann
and removed request for
kidrahahjo,
shihkual and
syjlee
tommy-waltmann
requested changes
Oct 13, 2023
tommy-waltmann
left a comment
tommy-waltmann
left a comment
There was a problem hiding this comment.
Looks to be in good shape, there appear to be CI issues and there is one small thing that I thought I should mention.
tommy-waltmann
approved these changes
Oct 13, 2023
Member
|
PyTorch is not yet available and won't until pytorch/pytorch#112882 is merged, so we will have to wait to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you @shihkual for this addition for our poster at MIDAS!