Updated the clibPath to point to the glibc directory that contains th…#1319
Updated the clibPath to point to the glibc directory that contains th…#1319wynan wants to merge 2 commits intogluonhq:masterfrom
Conversation
…e needed libraries. Updated the build.gradle file to address the gradle warnings.
johanvos
requested review from
abhinayagarwal and
tiainen
and removed request for
abhinayagarwal and
tiainen
|
|
||
| @Override | ||
| protected Path getCLibPath() { | ||
| return super.getCLibPath().resolve("glibc"); |
There was a problem hiding this comment.
Currently, the GluonFX 1.0.26 version is meant to be used with GraalVM 22.1.0.1-Final (JDK 17 based, from here https://github.com/gluonhq/graal/releases/), but nothing prevents you from using any other higher GraalVM version.
However, this is not recommended, as that in fact it will surely fail on Android/iOS (for instance, the CAP cache files change with new GraalVM versions, so the current ones in Substrate are guaranteed to work for a given GraalVM version).
The previous GluonFX 1.0.25, non-supported/experimental, version was meant to be used with GraalVM 23+25.1-dev, but that one is not failing with the error you have posted, because it doesn't use clibs.
So the error only happens in the unexpected combination of GluonFX 1.0.26 + GraalVM 23 + Linux x86_64. In any case, it doesn't happen on macOS.
If you want to move forward with this PR, I suggest you move this change to the LinuxTargetConfiguration class, and then you can check if the directory glibc exists before adding it to the path.
3 participants
Updated the clibPath in the Posix Configuration based on the information here and based on the location of my local files.
Updated the build.gradle file to address the gradle warnings.
Issue
Fixes #1318
Progress