Remove duplicated strings from link command#926
Open
jperedadnr wants to merge 1 commit intogluonhq:masterfrom
Open
Remove duplicated strings from link command#926jperedadnr wants to merge 1 commit intogluonhq:masterfrom
jperedadnr wants to merge 1 commit intogluonhq:masterfrom
Conversation
johanvos
reviewed
Apr 28, 2021
|
|
||
| /** | ||
| * Removes duplicated strings from a sourceList list, keeping the items with higher index | ||
| * in the list. Any item in the keep list will not be removed. |
Contributor
There was a problem hiding this comment.
that is not guaranteed to be the correct approach. If an entry appear twice, there are a number of possible scenario's. Both may be needed, first may be needed, last may be needed.
Contributor
Author
There was a problem hiding this comment.
There is a keep list for strings that might be duplicated and needed.
So far the case I found is the whole/no-whole combination.
I've tested this PR in all possible platforms, and there was no issue removing the rest of the duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #924
Progress