This repository was archived by the owner on Mar 26, 2020. It is now read-only.
Open
Conversation
Contributor
|
Please ensure cli coverage & e2e tests are in place as well.
On Tue, 12 Jun 2018 at 11:33, Rishubh Jain ***@***.***> wrote:
WIP
------------------------------
You can view, comment on, or merge this pull request online at:
#879
Commit Summary
- Volume shrink api
File Changes
- *M* glusterd2/commands/volumes/commands.go
<https://github.com/gluster/glusterd2/pull/879/files#diff-0> (9)
- *A* glusterd2/commands/volumes/volume-shrink.go
<https://github.com/gluster/glusterd2/pull/879/files#diff-1> (204)
- *M* pkg/api/volume_req.go
<https://github.com/gluster/glusterd2/pull/879/files#diff-2> (5)
- *M* pkg/api/volume_resp.go
<https://github.com/gluster/glusterd2/pull/879/files#diff-3> (3)
Patch Links:
- https://github.com/gluster/glusterd2/pull/879.patch
- https://github.com/gluster/glusterd2/pull/879.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#879>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGp7mNvMDTlsBtZ7XeC0MAIHkvPz0v99ks5t798vgaJpZM4UkqzL>
.
--
- Atin (atinm)
|
3a80aac to
4707158
Compare
8fbd082 to
bdce89d
Compare
3180496 to
1361dcd
Compare
1361dcd to
ea74829
Compare
Member
|
@rishubhjain please cover Rest client API implementation and e2e for this. |
Member
|
Please update issue #426 with details before starting the implementation. Different approaches to be followed for each Volume type, allowed operations etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP