:checked handler doesn't raise error when value is blank#129
Open
wheeyls wants to merge 1 commit intogmac:masterfrom
Open
:checked handler doesn't raise error when value is blank#129wheeyls wants to merge 1 commit intogmac:masterfrom
wheeyls wants to merge 1 commit intogmac:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is no value for a model, and no checkbox is checked on page load, this checked handler throws an error.
Making a change to bail out instead of trying to set the value if there is no matching radio to set. I tried to get a spec written for this but running
grunt testyielded an error:running "mocha_phantomjs:all" (mocha_phantomjs) task Test Failed to start mocha: Init timeout Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file:///Users/mike/code/backbone.epoxy/node_modules/grunt-mocha-phantomjs/node_modules/mocha-phantomjs/lib/mocha-phantomjs.coffee. Domains, protocols and ports must match.Not sure how up to date your tests are, but I didn't want to monkey with that.