add Flux Bidder Adapter#1
Open
gn-daikichi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語の説明
prebid公式でマージリクエストを出すときはここは消します。
これをマージ後、prebid公式にマージリクエストを出します。
Jira
ALD-2160
主な作業内容
prebid#4439
prebid#4908
上のプルリクでの作業内容を参考にアダプターを生成しました。
ただし、一部の箇所はテストが落ちたので書き方を変えました。
また、spec jsは古い物だとテスト通らない&網羅率が低かったので全体的に書き換えました。
確認項目
テストページhttps://another.geniee.jp/test/teranishi/prebid/flux/test.html
テスト枠https://geniee.slack.com/archives/C012H38442D/p1628648842119100?thread_ts=1627953199.041100&cid=C012H38442D
gulp test --file "test/spec/modules/fluxBidAdapter_spec.js"でテストが通ることを確認しましたType of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information