fix opening files with absolute Path from builders error log output - #35
Open
buzzdeee wants to merge 1 commit into
Open
fix opening files with absolute Path from builders error log output#35buzzdeee wants to merge 1 commit into
buzzdeee wants to merge 1 commit into
Conversation
error output, then the current buildPath is prepended, which is wrong. Before prepending that, check if the file isAbsolutePath, and only prepend buildPath, when not.
Member
|
@buzzdeee is there an example or a way to reproduce this? Any public project that causes such an issue? I wonder why you didn't include me for a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are files with absolute Paths in the PCProjectBuilder
error output, then the current buildPath is prepended, which is wrong.
Before prepending that, check if the file isAbsolutePath, and only prepend buildPath, when not.