Skip to content

CFCalendar: swap the minimum and maximum unit ranges #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DTW-Thalion wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CFCalendar: swap the minimum and maximum unit ranges #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/CFCalendar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,13 +832,13 @@ CFRange
CFCalendarGetMaximumRangeOfUnit (CFCalendarRef cal, CFCalendarUnit unit)
{
return CFCalendarGetMinMaxRangeOfUnit (cal, unit,
UCAL_GREATEST_MINIMUM, UCAL_LEAST_MAXIMUM);
UCAL_MINIMUM, UCAL_MAXIMUM);
}

CFRange
CFCalendarGetMinimumRangeOfUnit (CFCalendarRef cal, CFCalendarUnit unit)
{
return CFCalendarGetMinMaxRangeOfUnit (cal, unit,
UCAL_MINIMUM, UCAL_MAXIMUM);
UCAL_GREATEST_MINIMUM, UCAL_LEAST_MAXIMUM);
}

28 changes: 28 additions & 0 deletions Tests/CFCalendar/ranges.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#include "CoreFoundation/CFCalendar.h"
#include "CoreFoundation/CFTimeZone.h"
#include "../CFTesting.h"

/* CFCalendarGetMaximumRangeOfUnit is the widest a unit can be, and
CFCalendarGetMinimumRangeOfUnit is the narrowest. */

int main (void)
{
CFTimeZoneRef gmt = CFTimeZoneCreateWithTimeIntervalFromGMT (NULL, 0.0);
CFCalendarRef cal = CFCalendarCreateWithIdentifier (NULL,
kCFGregorianCalendar);
CFRange r;

CFCalendarSetTimeZone (cal, gmt);

r = CFCalendarGetMaximumRangeOfUnit (cal, kCFCalendarUnitDay);
PASS_CF (r.location == 1 && r.length == 31,
"The maximum day-of-month range is 1 to 31.");

r = CFCalendarGetMinimumRangeOfUnit (cal, kCFCalendarUnitDay);
PASS_CF (r.location == 1 && r.length == 28,
"The minimum day-of-month range is 1 to 28.");

CFRelease (cal);
CFRelease (gmt);
return 0;
}
Loading