CFCalendar: implement ordinality and range of a unit - #135
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
CFCalendarGetOrdinalityOfUnit and CFCalendarGetRangeOfUnit were stubs that returned kCFNotFound. Map the smaller unit measured within the bigger one to the corresponding ICU field and read its value, or its actual minimum and maximum, for the date in question.
DTW-Thalion
force-pushed
the
fix/cfcalendar-ordinality
branch
from
July 24, 2026 15:22
d361362 to
aa481be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFCalendarGetOrdinalityOfUnit and CFCalendarGetRangeOfUnit were stubs that returned kCFNotFound.
Implement them: map the smaller unit measured within the bigger unit to the corresponding ICU field (day within month is the day of the month, day within year the day of the year, month within year the month, and so on), set the calendar to the given time, and read either the field value (ordinality) or its actual minimum and maximum (range). Months are adjusted from ICU zero-based numbering.
Tests/CFCalendar/ordinality.m covers the day range of a 28-day and a 31-day month and the day-of-month, day-of-year and month-of-year ordinalities, verified against Apple CoreFoundation.