Skip to content

CFRunLoop: mark a new observer valid #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DTW-Thalion wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CFRunLoop: mark a new observer valid #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ccb4b
CFRunLoop: mark a new observer valid
DTW-Thalion Jul 22, 2026
706f282
Tests: release the observer in the CFRunLoop validity test
DTW-Thalion Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/CFRunLoop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,7 @@ CFRunLoopObserverCreate (CFAllocatorRef alloc, CFOptionFlags activities,
if (new)
{
GSMutexInitialize (&(new->_lock));
new->_isValid = true;
new->_activities = activities;
new->_repeats = repeats;
new->_order = order;
Expand Down
22 changes: 22 additions & 0 deletions Tests/CFRunLoop/observer_valid.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#include "CoreFoundation/CFRunLoop.h"
#include "../CFTesting.h"

static void
observe (CFRunLoopObserverRef o, CFRunLoopActivity a, void *info)
{
}

int main (void)
{
CFRunLoopObserverRef obs = CFRunLoopObserverCreate (NULL,
kCFRunLoopBeforeWaiting, false, 0, observe, NULL);

PASS_CF (CFRunLoopObserverIsValid (obs) == true, "A new observer is valid.");

CFRunLoopObserverInvalidate (obs);
PASS_CF (CFRunLoopObserverIsValid (obs) == false,
"An invalidated observer is no longer valid.");

CFRelease (obs);
return 0;
}
Loading