Fix: correct CFStream memory-stream status and error reporting - #145
Open
DTW-Thalion wants to merge 1 commit into
Open
Fix: correct CFStream memory-stream status and error reporting#145DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix-cfstream-memory-status-error
branch
from
July 24, 2026 15:22
6fce08e to
d0192c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four corrections to the memory-backed CFReadStream and CFWriteStream, each verified against Apple CoreFoundation.
CFReadStreamGetStatus returns kCFStreamStatusAtEnd once a stream is fully consumed instead of staying Open; a new atEnd flag is set when a read or CFReadStreamGetBuffer reaches the end of the buffer.
CFReadStreamHasBytesAvailable returns false before the stream is opened and after it is closed, rather than always consulting the buffer.
CFWriteStreamWrite on a fixed-capacity buffer that cannot hold the data fails with -1, sets the Error status and reports POSIX ENOMEM, instead of silently truncating the write.
CFStreamGetError reports domain 0 for a stream with no error, instead of kCFStreamErrorDomainPOSIX.
The tests read_atend.m, read_unopened.m, write_overflow.m and no_error.m fail before these changes and pass after.