Fix: implement CFXML entity escaping and unescaping - #153
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
CFXMLCreateStringByEscapingEntities and CFXMLCreateStringByUnescapingEntities returned NULL. Escaping replaces the five predefined XML entities (&, <, >, " and ') with their references and copies other characters unchanged. Unescaping resolves those five named entities, decimal and hexadecimal numeric character references, and any names present in the supplied entities dictionary.
DTW-Thalion
force-pushed
the
fix-cfxmlparser-escaping
branch
from
July 24, 2026 15:22
83fe9f9 to
077f52d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFXMLCreateStringByEscapingEntities and CFXMLCreateStringByUnescapingEntities returned NULL. Escaping now replaces the five predefined XML entities (&, <, >, " and ') with their references and copies other characters unchanged. Unescaping resolves those five named entities, decimal and hexadecimal numeric character references, and any names present in the supplied entities dictionary.
Tests/CFXMLParser/escaping.m covers both directions against values taken from Apple CoreFoundation. It fails before this change (the functions return NULL) and passes after.