Cast the pointers InterlockedCompareExchangePointer is given - #160
Open
DTW-Thalion wants to merge 1 commit into
Open
Cast the pointers InterlockedCompareExchangePointer is given#160DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
Every other atomic macro in the _WIN32 branch casts its arguments, to LONGLONG volatile* or LONG volatile*. The pointer one passed its arguments through untouched, so a caller holding a typed pointer, such as CFTimeZoneRef* in CFTimeZone.c, does not compile: the parameter is PVOID volatile*. The other branch uses __sync_val_compare_and_swap, which is type generic, so this only shows up on Windows.
DTW-Thalion
marked this pull request as ready for review
August 14, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every atomic macro in the _WIN32 branch of GSPrivate.h casts what it is given, to LONGLONG volatile* or LONG volatile*. GSAtomicCompareAndSwapPointer passes its arguments through untouched, and InterlockedCompareExchangePointer takes PVOID volatile*.
A caller holding a typed pointer therefore does not compile. CFTimeZone.c has 6 of them, passing CFTimeZoneRef* and CFDictionaryRef*.
The other branch uses __sync_val_compare_and_swap, which is type generic, so this only appears on Windows.
Found building on MSYS2 ucrt64 with clang 22.