Fix github workflow to adopt pattern used by other core libs#17
Merged
Conversation
Member
|
Thank you for looking into this. Looks great to me. Having support for gcc would be great. I remember when I last worked on opal, I managed to compile it with gcc. But this was without libdispatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fredkiefer here is a working GitHub workflow with scripts modeled after libs-gui.
You can preview the runs here:
https://github.com/pkgdemon/libs-opal/actions/runs/24934116279
Let me know what you think. I did attempt to add GCC to the matrix as well, but it seems libs-corebase requires libdispatch, and I could not find a way to make that work yet so I kept only Clang in the matrix for now.