Skip to content

Fix LogTraceParams.Verbose type #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanvanburen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix LogTraceParams.Verbose type #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion general.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ type LogTraceParams struct {

// Verbose is the additional information that can be computed if the "trace" configuration
// is set to "verbose".
Verbose TraceValue `json:"verbose,omitempty"`
Verbose string `json:"verbose,omitempty"`
}

// SetTraceParams params of SetTrace notification.
Expand Down
4 changes: 2 additions & 2 deletions general_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,12 +341,12 @@ func TestLogTraceParams(t *testing.T) {
t.Parallel()

const (
want = `{"message":"testMessage","verbose":"verbose"}`
want = `{"message":"testMessage","verbose":"testVerbose"}`
wantNil = `{"message":"testMessage"}`
)
wantType := LogTraceParams{
Message: "testMessage",
Verbose: TraceVerbose,
Verbose: "testVerbose",
}
wantTypeNil := LogTraceParams{
Message: "testMessage",
Expand Down