refactor: rename purego_ → goffi_ in fakecgo + copyright update - #63
Merged
Conversation
Rename all dynamic import symbols from purego_ prefix to goffi_ to reflect project identity. The fakecgo package was originally a snapshot of ebitengine/purego's internal/fakecgo (~2024). The purego_ naming was inherited but is inconsistent with the rest of the codebase (internal/dl and internal/syscall use goffi_ prefix). Add GoGPU copyright alongside original Ebitengine Authors attribution as required by Apache-2.0 license.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
besmpl
added a commit
to besmpl/goffi
that referenced
this pull request
Jul 21, 2026
Document and assert the runtime.iscgo wiring selected by Android's implicit linux build tag, keep RTLD policy internal, split TLS startup diagnostics, and align all Android fakecgo imports with the goffi_ prefix introduced by go-webgpu#63.
kolkov
pushed a commit
that referenced
this pull request
Jul 21, 2026
* feat: add Android Bionic loader and errno support * feat: add Android arm64 fakecgo startup guard * test: add Android probes and preview documentation * fix: address Android runtime review feedback Document and assert the runtime.iscgo wiring selected by Android's implicit linux build tag, keep RTLD policy internal, split TLS startup diagnostics, and align all Android fakecgo imports with the goffi_ prefix introduced by #63.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
purego_dynamic import symbols togoffi_ininternal/fakecgo/(gen.go template, 4 generated symbols files, assembly stubs)Andrey Kolkov and GoGPU Contributors(matching gogpu ecosystem pattern)The Goffi AuthorstoAndrey Kolkov and GoGPU ContributorsWhy
The
purego_naming and sole Ebitengine copyright were inherited from our purego fakecgo snapshot (~2024) and never updated. The rest of the codebase (internal/dl/,internal/syscall/) usesgoffi_prefix. This cleanup aligns naming across the project and establishes proper dual copyright attribution.Test plan
purego_references remaining in fakecgogo fmt,go build,go test— all clean