fix: ARM64 HFA return checkptr crash + 9-16B struct corruption (v0.6.3) - #68
Merged
Conversation
…loses #67) handleHFAReturn cast (*[4]float64)(rvalue) was oversized for 2-3 element HFAs — checkptr detected the cast spanning beyond the rvalue allocation. Fix: per-element writes via unsafe.Add, matching existing single-element pattern. Also fix (*[2]uint64)(rvalue) for 9-16B struct returns — wrote 8 full bytes for hi word even when struct < 16 bytes. Fix: copy with exact remaining size, matching AMD64 pattern. Proactive — checkptr doesn't catch this (GC pads to 16) but packed C structs could corrupt.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleHFAReturncheckptr crash:(*[4]float64)(rvalue)oversized for 2-3 element HFAs (CGSize/CGPoint = 16 bytes, cast = 32 bytes).go test -racecrashed with "converted pointer straddles multiple allocations"(*[2]uint64)(rvalue)for 9-16B struct returns: wrote 8 full bytes for hi word when struct < 16 bytes. Proactive fix — checkptr doesn't catch this (GC pads to 16) but packed C structs could corruptunsafe.Add/copyper-element, matching AMD64 patternsTest plan
go build ./...— cleango test ./...— all passgolangci-lint: 0 issuesTestHandleHFAReturn_Checkptr+TestHandleHFAReturn_Float32addedCloses #67