Fix state after returning new state object from reduce.#645
Open
JorgenEvens wants to merge 3 commits intogoatslacker:masterfrom
Open
Fix state after returning new state object from reduce.#645JorgenEvens wants to merge 3 commits intogoatslacker:masterfrom
JorgenEvens wants to merge 3 commits intogoatslacker:masterfrom
Conversation
JorgenEvens
force-pushed
the
bug/model-state-unaffected
branch
from
37b8e1b to
5a1d94e
Compare
Author
|
I've added node 5.11 to the list of node engines to test on Travis-CI as Babel does not seem to be to happy with node v6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After returning a new state object from a reduce method there are now two state objects being used by the store. The one stored on
model.stateand the one stored on theAltStoreinstance.The easiest way to see this is by checking whether the state passed into the
reducemethod is the same as that available onthis( the model as reduce is called on it ). I would expect it to be, but it is not.