CI: Update fgvm calls to use which in order to resolve the path. - #1040
Open
patricktcoakley wants to merge 1 commit into
Open
CI: Update fgvm calls to use which in order to resolve the path.#1040patricktcoakley wants to merge 1 commit into
which in order to resolve the path.#1040patricktcoakley wants to merge 1 commit into
Conversation
patricktcoakley
changed the title
which in order to resolve the path.which in order to resolve the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm the maintainer of fgvm, which is being used in the CI. I noticed an issue with some failed runs where it couldn't find the path, and wanted to offer a better way to resolve the path using the
whichcommand, which I recently updated a few weeks ago to take a query that filters it to the closes installation and only prints the path. The FGVM_HOME path was mostly used for testing purposes and I ended up making a breaking change that effects the current resolver code, but usingwhichsolves that in a cleaner manner.