Local support of locales serve for theme#395
Open
KunalFynd wants to merge 39 commits intotheme-sections-chunkingfrom
Open
Local support of locales serve for theme#395KunalFynd wants to merge 39 commits intotheme-sections-chunkingfrom
KunalFynd wants to merge 39 commits intotheme-sections-chunkingfrom
Conversation
src/helper/locales.ts
Outdated
|
|
||
| Logger.debug('Response received from API:', response.status); | ||
|
|
||
| if (response.status === 200) { |
Collaborator
There was a problem hiding this comment.
early return with invalid case
src/helper/locales.ts
Outdated
| Logger.debug('Remote data retrieved:', data); | ||
|
|
||
| // Ensure the locales folder exists | ||
| await fs.mkdir(localesFolder, { recursive: true }); |
Collaborator
There was a problem hiding this comment.
check why recursive is used, check if it is required
src/helper/locales.ts
Outdated
| try { | ||
| Logger.debug('Starting comparison between local and remote data'); | ||
|
|
||
| const localesFolder: string = path.resolve(process.cwd(), 'theme/locales'); |
Collaborator
There was a problem hiding this comment.
done use slash here
src/helper/locales.ts
Outdated
| return true; // Changes detected | ||
| } | ||
|
|
||
| if (JSON.stringify(localData) !== JSON.stringify(matchingItem.resource)) { // Compare the local and remote data |
src/helper/locales.ts
Outdated
| localData = JSON.parse(await fs.readFile(path.join(localesFolder, file), 'utf-8')); | ||
| } catch (err) { | ||
| Logger.error(`Error reading file ${file}: ${(err as Error).message}`); | ||
| continue; |
Collaborator
There was a problem hiding this comment.
Throw error and show file name that has incorrect data
| } | ||
| }); | ||
|
|
||
| res.json({"items":localesArray}); |
section chunking by removing from main bundle React
An error occurred while trying to automatically change base from
theme-sections-chunking
to
master
May 20, 2025 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.