refactor(widget): decouple from gg/scene with SceneCache interface (ADR-036) - #210
Merged
Conversation
…DR-036) Replace *scene.Scene with SceneCache interface in widget package. Third-party imports compile 71 packages instead of 124 (zero gg deps). SceneFactory registration follows existing SceneRecorder DI pattern. deps: gg v0.50.12, gogpu v0.50.0, wgpu v0.30.36
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*scene.Scenein widget package — third-party widget authors no longer compile gg/wgpu/nagaimport widget+geometry+event→ 124 packages (18 gogpu, including all of gg)import widget+geometry+event→ 71 packages (4 gogpu, zero gg)Details
ADR-036 Phase 1. widget/ used only 2 operations from scene.Scene:
NewScene()andReset(). Everything else was opaque pass-through. Replaced with:widget.SceneCacheinterface (Reset(),IsEmpty())widget.SceneFactory+widget.RegisterSceneFactory()+widget.NewSceneCache()*scene.Sceneneeded92 files changed (mostly test mock signature updates). Zero behavior change.
Test plan
grep "gogpu/gg" widget/*.go | grep -v _test= zero resultsgo build ./...go test ./... -count=1(61 packages, 0 fail)golangci-lint run --timeout=5m(0 issues)