feat(widgets): auto-play UI sound feedback + deps cascade (ADR-037) - #215
Merged
Conversation
widget.PlaySound() DI pattern — widgets play sound.Click on interaction without importing gogpu/sound. desktop/sound.go bridges via RegisterSoundPlayer. Auto-play: button, checkbox, radio, dropdown, collapsible, tabview, dialog, menu. No sound on slider (continuous drag). SoundAlert for dialog Show(). Sound before user callback for immediate feedback.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widget.PlaySound()DI pattern. Zerosound.Play()in user code.Auto-play widgets (SoundClick)
button, checkbox, radio, dropdown, collapsible, tabview, menu
Special sounds
Architecture (ADR-037)
widget.RegisterSoundPlayer()callback DI — widget/ never imports gogpu.desktop/sound.gobridges viainit().New files
widget/sound.go— SoundEvent, SoundPlayer, PlaySounddesktop/sound.go— bridge registrationwidget/sound_test.go— 3 testsExample
examples/sounds/updated —sound.SetEnabled(true)only, widgets auto-clickTest plan
GOWORK=off go build ./...go test ./... -count=1(61 packages)golangci-lint run --timeout=5m(0 issues)