Skip to content

test(metal): align storage-mode fixture with GPU policy #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolkov merged 1 commit into from
Jul 24, 2026
Merged

test(metal): align storage-mode fixture with GPU policy #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions hal/metal/texture_copy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ func TestCommandEncoderCopiesBetweenLayeredTextures(t *testing.T) {

func TestQueueWriteTextureLayeredShapes(t *testing.T) {
device, queue := newMetalTextureCopyTestDevice(t)
hasUnifiedMemory := device.hasUnifiedMemory
supportsSharedTextures := device.isAppleGPU

shapes := []struct {
name string
Expand All @@ -471,10 +471,10 @@ func TestQueueWriteTextureLayeredShapes(t *testing.T) {
for _, shape := range shapes {
for _, storage := range storageModes {
t.Run(shape.name+"/"+storage.name, func(t *testing.T) {
if storage.shared && !hasUnifiedMemory {
t.Skip("direct Shared-texture writes require unified memory")
if storage.shared && !supportsSharedTextures {
t.Skip("direct Shared-texture writes require an Apple GPU family")
}
device.hasUnifiedMemory = storage.shared
device.isAppleGPU = storage.shared

const (
width = uint32(4)
Expand Down
Loading