Skip to content

fix(surface): handle nil WritePixels receiver #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolkov merged 1 commit into from
Jul 25, 2026
Merged

fix(surface): handle nil WritePixels receiver #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions headless_surface_native_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,3 +363,10 @@ func TestHeadlessSurfaceReadPixelsStateErrors(t *testing.T) {
}
})
}

func TestSurfaceWritePixelsNil(t *testing.T) {
var surface *Surface
if err := surface.WritePixels(nil, 0, 0); !errors.Is(err, ErrReleased) {
t.Fatalf("WritePixels error = %v, want ErrReleased", err)
}
}
2 changes: 1 addition & 1 deletion surface_native.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ func (s *Surface) PresentPixels(data []byte, width, height uint32, damageRects [
// Call between GetCurrentTexture() and Present(). No render pass needed.
// Returns ErrReleased if the surface is not configured.
func (s *Surface) WritePixels(data []byte, width, height uint32) error {
if s.released || s.core == nil {
if s == nil || s.released || s.core == nil {
return ErrReleased
}
raw := s.core.RawSurface()
Expand Down
Loading