fix(vulkan): accumulated present semaphores for multi-submit sync (ADR-058) - #302
Merged
Conversation
…R-058) Per-image semaphore pool replaces single present semaphore. Each queue.Submit() signals a new semaphore from the pool, vkQueuePresentKHR waits on all accumulated semaphores. Fixes g3d#22 race on TBDR GPUs (Asahi Linux) where only the first submit was synchronized with present. Rust wgpu SwapchainPresentSemaphores parity (native.rs:743-843). Pools grow on demand, recycle after present — zero overhead for the common single-submit-per-frame case.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queue.Submit()calls target the same swapchain image per frame (g3d#22)vkQueuePresentKHRwaits on all accumulated semaphoresSwapchainPresentSemaphoresparity (native.rs:743-843)Test plan
go build ./...— Windows, Linux, macOS, WASMgo test -count=1 ./...— 18 packages, 0 failuresgolangci-lint run— 0 issues (Win/Linux/macOS)swapchain_fail_closed_test.goupdated for new pool structGOGPU_GRAPHICS_API=vulkang3d fullscreen-overlay — needs Asahi Linux tester (@porjo)