fix(vulkan): align swapchain FinalLayout with Rust wgpu/Dawn (ADR-059) - #304
Merged
Conversation
Render passes for swapchain images now use COLOR_ATTACHMENT_OPTIMAL instead of PRESENT_SRC_KHR as FinalLayout. Explicit barrier to PRESENT_SRC_KHR in ensurePresentLayout() before present. Eliminated synchronous vkWaitForFences GPU stall — barrier submit uses no fence, command pool reset deferred to acquireNextImage() where acquire fence guarantees completion. Matches Rust wgpu (device.rs:119-120) and Dawn (RenderPassCache.cpp:173-174).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COLOR_ATTACHMENT_OPTIMALinstead ofPRESENT_SRC_KHRas FinalLayoutCOLOR_ATTACHMENT_OPTIMAL → PRESENT_SRC_KHRinensurePresentLayout()before presentvkWaitForFencesGPU stall — deferred command pool reset toacquireNextImage()device.rs:119-120) and Dawn (RenderPassCache.cpp:173-174)Test plan
go build ./...— Windows, Linux, macOS, WASMgo test -count=1 ./...— 18 packages, 0 failuresgolangci-lint run— 0 issues