feat: added jobservice pools, workers, jobs subcommand#796
feat: added jobservice pools, workers, jobs subcommand#796NishchayRajput wants to merge 4 commits into
Conversation
|
Can you convert this to a draft, since this would cause conflicts with the other PR #795 |
qcserestipy
left a comment
There was a problem hiding this comment.
In principle LGTM, the commands however should be only accessible for admins. Please make sure that a user needs elevated priviledges.
c46608b to
15e145e
Compare
15e145e to
20a261e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=========================================
- Coverage 10.99% 9.42% -1.57%
=========================================
Files 173 293 +120
Lines 8671 14277 +5606
=========================================
+ Hits 953 1346 +393
- Misses 7612 12806 +5194
- Partials 106 125 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qcserestipy
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I added several nit picks here and there.
Thanks for reviewing. Will do the required changes by today. |
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
626d445 to
524cc93
Compare
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Description
Briefly describe what this pull request does and why the change is needed.
This PR adds the remaining jobservice subcommands under
harbor jobservicefor workers, worker pools, and job logs.It improves CLI parity with the Harbor Job Service dashboard by exposing worker pool listing, worker listing with pagination, and job log viewing from the CLI.
Type of Change
Please select the relevant type.
Changes
pools list.workers list,workers free,workers free-all.jobs log.Command and Flag Behavior
Commands added
harbor jobservice pools listharbor jobservice workers listharbor jobservice workers freeharbor jobservice workers free-allharbor jobservice jobs logSupported flags by command
harbor jobservice pools list--output-format json|yamlharbor jobservice workers list--pool <pool-id|all>--all--pool-all(compatibility alias)--page--page-size[POOL_ID]for backward compatibility--output-format json|yamlharbor jobservice workers free--job-id(required)harbor jobservice workers free-allharbor jobservice jobs log--job-id(required)Default behavior
workers listdefaults to all pools when no pool selector is provided.workers listdefaults to page1and page-size20.workers listpaginates in the CLI because the backend API only acceptspool_id.workers freestops the single job identified by--job-id.workers free-allstops all running jobs to free busy workers.jobs logprints the selected job log and returns a clear empty-state message when no log content is available.